add test, adapt error message. #734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaeldeistler
requested changes
Aug 26, 2022
tests/linearGaussian_snpe_test.py
Outdated
|
|
||
| proposal = estimator.build_posterior().set_default_x(x_o) | ||
| samples.append(proposal.sample((num_simulations,))) | ||
| fig, ax = pairplot( |
There was a problem hiding this comment.
Why do we pairplot and save?
tests/linearGaussian_snpe_test.py
Outdated
| "num_simulations", | ||
| (5000, 10000, 15000), | ||
| ) | ||
| @pytest.mark.parametrize("density_estimator", ("mdn", "nsf", "maf")) |
There was a problem hiding this comment.
why test nsf and maf in this test?
| log_prob_proposal_posterior, | ||
| """the evaluation of the MoG proposal posterior. This is likely due to too | ||
| little training data---consider increasing your simulation budget.""", | ||
| ) |
There was a problem hiding this comment.
I'm not 100% sure about this -- are you still observing the failure with low simulation-budgets after the fix?
tests/linearGaussian_snpe_test.py
Outdated
| @@ -627,3 +627,68 @@ def test_example_posterior(snpe_method: type): | |||
| prior=prior, posterior_estimator=posterior_estimator | |||
| ).set_default_x(x_o) | |||
| assert posterior is not None | |||
|
|
|||
|
|
|||
| @pytest.mark.parametrize("num_dim", (10, 12, 14)) | |||
There was a problem hiding this comment.
we should mark this as slow, no?
michaeldeistler
approved these changes
Aug 26, 2022
michaeldeistler
force-pushed
the
mog-training-nans
branch
from
fa3571e
to
c0736d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #733
@michaeldeistler feel free to adapt and merge.