Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add x batch dim in sbc loop. #838

Merged
merged 1 commit into from
Apr 26, 2023
Merged

Conversation

janfb
Copy link
Contributor

@janfb janfb commented Apr 26, 2023

fixes #837

@janfb janfb added the bug Something isn't working label Apr 26, 2023
@janfb janfb self-assigned this Apr 26, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #838 (3c1c841) into main (5768a7c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main     #838   +/-   ##
=======================================
  Coverage   74.59%   74.59%           
=======================================
  Files          80       80           
  Lines        6235     6236    +1     
=======================================
+ Hits         4651     4652    +1     
  Misses       1584     1584           
Flag Coverage Δ
unittests 74.59% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sbi/analysis/sbc.py 95.29% <100.00%> (+0.05%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@michaeldeistler michaeldeistler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@janfb janfb merged commit 86e73a9 into main Apr 26, 2023
@janfb janfb deleted the fix-sbc-with-embedding-nets branch April 26, 2023 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SBC fails with embedding nets if x.ndim > 1.
3 participants