Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--update/--update-all not working in some edge cases #24

Open
sbidoul opened this issue Jul 21, 2020 · 1 comment
Open

--update/--update-all not working in some edge cases #24

sbidoul opened this issue Jul 21, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@sbidoul
Copy link
Owner

sbidoul commented Jul 21, 2020 •
edited
Loading

When a new dependency is added to the project, and it is already installed while not being part of requirements.txt, using --update or --update-all may not update it to the latest available version.

This is a very edge case that is probably not an issue in practice.
@sbidoul sbidoul added the bug Something isn't working label Jul 21, 2020
sbidoul added a commit that referenced this issue Jul 21, 2020
@sbidoul
Add xfail tests for issue #24
4baed7b
@sbidoul sbidoul changed the title --update/--update-all not working in some cases --update/--update-all not working in some edge cases Aug 7, 2020
@sbidoul
Copy link
Owner Author

sbidoul commented Aug 22, 2020

To fix this we can compute the following set after pip-df-sync: ( {installed before} \ {installed dependencies before} ) ∩ { installed dependencies after }. If it is not empty, run a second pass.

Alternatively, I should dig into pip upgrade strategies and make sure they work for all our use cases (direct URLs, etc).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sbidoul