Fix reporting available scenes on RGB devices #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should be the last PR for today. If you have time, a release would be great as well as I might be able to get the remotes working after dinner. |
- Add coverage for scenes
Codecov Report
@@ Coverage Diff @@
## master #121 +/- ##
==========================================
+ Coverage 76.89% 77.36% +0.47%
==========================================
Files 12 12
Lines 779 782 +3
==========================================
+ Hits 599 605 +6
+ Misses 180 177 -3
Continue to review full report at Codecov.
|
bdraco
added a commit
to bdraco/home-assistant
that referenced
this pull request
Feb 11, 2022
- Setup is now retried later in case the wifi was unstable for a moment during setup Requires sbidy/pywizlight#121 Changelog: sbidy/pywizlight@v0.5.5...v0.5.6 Fixes ``` 2022-02-10 18:07:19 ERROR (MainThread) [homeassistant.components.light] Error while setting up wiz platform for light Traceback (most recent call last): File "/Users/bdraco/home-assistant/homeassistant/helpers/entity_platform.py", line 249, in _async_setup_platform await asyncio.shield(task) File "/Users/bdraco/home-assistant/homeassistant/components/wiz/light.py", line 69, in async_setup_entry async_add_entities([WizBulbEntity(wiz_data, entry.title)]) File "/Users/bdraco/home-assistant/homeassistant/components/wiz/light.py", line 94, in __init__ bulb_type.kelvin_range.max AttributeError: NoneType object has no attribute max ```
22 tasks
|
Reviewed, merged and release created. Sorry for the delay 😄 - there are some timezones between us. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add coverage for scenes
Change ValueError to
WizLightNotKnownBulbsince they are thrown for similar cases which supports Fix WiZ bulb being offline if kelvin limits cannot be obtained home-assistant/core#66305