Implement progressive backoff and improve error reporting #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #126 +/- ##
==========================================
+ Coverage 87.34% 87.43% +0.09%
==========================================
Files 12 12
Lines 782 788 +6
==========================================
+ Hits 683 689 +6
Misses 99 99
Continue to review full report at Codecov.
|
bdraco
changed the title
|
It would be good to get a release for this one. |
|
0.5.7 on the way |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We needed to wait a little bit longer for the OSError's to come back so we now backoff progressively up to 3s between sends and increases the timeout to 13s since it can take a few more seconds for error to arrive. This means we now get a much better error when the bulb is offline, and we aren't making a situation where the problem is wifi congestion even worse.
Also since we are using a future, it doesn't matter which udp message the bulb gets and respond to, since as soon as it does, the send task will be canceled and we will declare success.