Fix missing effects on dimmable white bulbs and add test coverage #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #129 +/- ##
==========================================
+ Coverage 87.56% 87.93% +0.37%
==========================================
Files 12 12
Lines 796 796
==========================================
+ Hits 697 700 +3
+ Misses 99 96 -3
Continue to review full report at Codecov.
|
bdraco
changed the title
|
This once could use a new release when you have a moment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far nothing has broken with the older devices I have been receiving from ebay. Effects are missing from dimmable white bulbsI'm adding the output to the tests though so if we do change something or add support for a new thing in the future we will know if we broke old firmware compat.