Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compat with 1.8.0 firmware #134

Merged
merged 3 commits into from
Feb 20, 2022
Merged

Conversation

bdraco
Copy link
Contributor

@bdraco bdraco commented Feb 20, 2022

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Feb 20, 2022

Codecov Report

Merging #134 (b0c8e90) into master (ce6bc4d) will increase coverage by 0.24%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #134      +/-   ##
==========================================
+ Coverage   89.15%   89.39%   +0.24%     
==========================================
  Files          12       12              
  Lines         848      858      +10     
==========================================
+ Hits          756      767      +11     
+ Misses         92       91       -1     
Impacted Files Coverage Δ
pywizlight/bulb.py 90.48% <100.00%> (-0.03%) ⬇️
pywizlight/bulblibrary.py 100.00% <100.00%> (+1.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce6bc4d...b0c8e90. Read the comment docs.

@bdraco bdraco force-pushed the fix_180_firmware_compat branch 3 times, most recently from cd44892 to 60ae404 Compare February 20, 2022 20:17
@bdraco
Copy link
Contributor Author

bdraco commented Feb 20, 2022

I'll fix the conflict

@sbidy
Copy link
Owner

sbidy commented Feb 20, 2022

Ah, shit. I missed the draft.

@bdraco
Copy link
Contributor Author

bdraco commented Feb 20, 2022

@sbidy should be good now

@sbidy sbidy merged commit 9e37672 into sbidy:master Feb 20, 2022
@bdraco
Copy link
Contributor Author

bdraco commented Feb 20, 2022

Thanks @sbidy

Would you mind pushing a new release?

@sbidy
Copy link
Owner

sbidy commented Feb 20, 2022

Done

@bdraco
Copy link
Contributor Author

bdraco commented Feb 20, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants