Add support for wall switches #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdraco
force-pushed
the
test_more_devices
branch
3 times, most recently
from
d87b256
to
97e243e
Compare
Codecov Report
@@ Coverage Diff @@
## master #139 +/- ##
==========================================
+ Coverage 89.41% 90.96% +1.54%
==========================================
Files 12 12
Lines 869 874 +5
==========================================
+ Hits 777 795 +18
+ Misses 92 79 -13
Continue to review full report at Codecov.
|
bdraco
force-pushed
the
test_more_devices
branch
from
97e243e
to
8bff788
Compare
bdraco
changed the title
bdraco
force-pushed
the
test_more_devices
branch
from
8bff788
to
e5fc5f7
Compare
bdraco
added a commit
to bdraco/home-assistant
that referenced
this pull request
Feb 23, 2022
- The dimmer switch do not support effects - Requires sbidy/pywizlight#139
22 tasks
|
@sbidy This one is going to need another release when you get a chance. Thanks! |
|
Done - thank you! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wall Switches were showing effects but they don't have them
Also adds tests for hero device and discovery since they would conflict otherwise