-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/refactor and remeshing #142
Conversation
did this for cashocs.space_mapping and cashocs.nonlinear_solvers
Conflicts: cashocs/_optimization/optimization_problem.py
temp_dict is placed in the database state_problem and adjoint_problem are now defined commonly for both shape and optimal control
This is updated right away when the corresponding values are updated. This commit achieves a decoupling from io from the solver and optimization problem
…sed) This is done to be better compatible with other solution approaches.
Fixed a bug with the remeshing dictionary not being read properly.
|
||
""" | ||
super().__init__(optimization_problem) | ||
super().__init__(optimization_problem, db) | ||
self.form_handler = cast(_forms.ShapeFormHandler, self.form_handler) |
Check warning
Code scanning / CodeQL
Overwriting attribute in super-class or sub-class
super().__init__(optimization_problem, db) | ||
|
||
self.box_constraints = box_constraints | ||
self.form_handler = cast(_forms.ControlFormHandler, self.form_handler) |
Check warning
Code scanning / CodeQL
Overwriting attribute in super-class or sub-class
self.current_barycenter_y.val = barycenter_list[1] | ||
self.current_barycenter_z.val = barycenter_list[2] | ||
if self.mu > 0.0: | ||
self.is_active = True |
Check warning
Code scanning / CodeQL
Overwriting attribute in super-class or sub-class
self.target_surface = self._compute_surface() | ||
|
||
if self.mu > 0.0: | ||
self.is_active = True |
Check warning
Code scanning / CodeQL
Overwriting attribute in super-class or sub-class
self.target_barycenter_list = self._compute_barycenter_list() | ||
|
||
if self.mu > 0.0: | ||
self.is_active = True |
Check warning
Code scanning / CodeQL
Overwriting attribute in super-class or sub-class
) | ||
|
||
if self.mu > 0: | ||
self.is_active = True |
Check warning
Code scanning / CodeQL
Overwriting attribute in super-class or sub-class
Codecov Report
@@ Coverage Diff @@
## main #142 +/- ##
==========================================
- Coverage 93.74% 93.71% -0.03%
==========================================
Files 65 75 +10
Lines 5637 5735 +98
==========================================
+ Hits 5284 5374 +90
- Misses 353 361 +8
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This is required for functools.singledispatchmethod.
This update includes a major refactoring of the code. In particular, the remeshing workflow is completely re-worked, which introduces backwards-incompatible changes.