Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a different criterion for the BFGS curvature test #263

Merged
merged 1 commit into from
Jul 5, 2023

Conversation

sblauth
Copy link
Owner

@sblauth sblauth commented Jul 5, 2023

Now, the criterion is an absolute one, in contrast to the previous implementation, where a relative one was used.
If a relative criterion is desired, damped BFGS should be chosen.

@sblauth sblauth added this to the v2.1 milestone Jul 5, 2023
@sblauth sblauth self-assigned this Jul 5, 2023
@sblauth sblauth enabled auto-merge July 5, 2023 10:25
@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Merging #263 (82902b7) into main (1903c87) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #263   +/-   ##
=======================================
  Coverage   92.59%   92.59%           
=======================================
  Files          83       83           
  Lines        6450     6450           
=======================================
  Hits         5972     5972           
  Misses        478      478           
Impacted Files Coverage Δ
...cs/_optimization/optimization_algorithms/l_bfgs.py 99.39% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sblauth sblauth merged commit 47e11f6 into main Jul 5, 2023
@sblauth sblauth deleted the development/bfgs_fix branch July 5, 2023 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant