DEV: Add the possibility to specifiy a minimum number of iterations for inner (linear) solvers in Newton's method #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is used to set a minimum number of iterations that the inner (linear) solver should perform.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov Report
@@ Coverage Diff @@
## main #343 +/- ##
==========================================
- Coverage 92.50% 92.48% -0.02%
==========================================
Files 84 84
Lines 6640 6648 +8
==========================================
+ Hits 6142 6148 +6
- Misses 498 500 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
I'll close this, as users can simply use the PETSc option "ksp_min_it" for specifying this. See #290 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the parameter
min_inner_iterto the Newton's method, which can be used to specify the minimum amount of iterations a linear solver (inner solver) has to perform regardless of termination criteria.Note, that this feature depends on PETSc >= 3.20 - so it only makes sense to merge this, once support for PETSc 3.20 exists (see #320)
Closes #290