Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate all options to constrained problems and space mapping #401

Merged
merged 2 commits into from
Mar 7, 2024

Conversation

sblauth
Copy link
Owner

@sblauth sblauth commented Mar 7, 2024

With this PR, all constrained problems and space mapping (parameter extraction and coarse model) can now accept all kwargs that the usual optimization problems can accept.

This means, that constrained problems and space mapping routines can now (again)
accept all parameters as the original problems
@sblauth sblauth added the bug Something isn't working label Mar 7, 2024
@sblauth sblauth self-assigned this Mar 7, 2024
Copy link

codecov bot commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.16%. Comparing base (f94d309) to head (83a5cf9).

Additional details and impacted files
@@               Coverage Diff                @@
##           hotfix/2.1.1     #401      +/-   ##
================================================
+ Coverage         92.13%   92.16%   +0.04%     
================================================
  Files                84       84              
  Lines              6743     6775      +32     
================================================
+ Hits               6212     6244      +32     
  Misses              531      531              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sblauth sblauth merged commit 2eec83a into hotfix/2.1.1 Mar 7, 2024
24 of 25 checks passed
@sblauth sblauth deleted the fix/propagate_options branch March 7, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant