Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/2.1.3: Fix a bug in the line search for space mapping shape optimization #445

Merged
merged 3 commits into from
Jun 27, 2024

Conversation

sblauth
Copy link
Owner

@sblauth sblauth commented Jun 27, 2024

This fixes a bug, where the mesh is not correctly reverted to the current iterate in the backtracking line search.

@sblauth sblauth added the bug Something isn't working label Jun 27, 2024
@sblauth sblauth self-assigned this Jun 27, 2024
Copy link

codecov bot commented Jun 27, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.07%. Comparing base (84adb31) to head (28a8f6c).
Report is 10 commits behind head on main.

Current head 28a8f6c differs from pull request most recent head 7ff79d4

Please upload reports for the commit 7ff79d4 to get more accurate results.

Files Patch % Lines
cashocs/space_mapping/shape_optimization.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #445      +/-   ##
==========================================
+ Coverage   91.54%   92.07%   +0.52%     
==========================================
  Files          85       83       -2     
  Lines        7344     6692     -652     
==========================================
- Hits         6723     6161     -562     
+ Misses        621      531      -90     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sblauth sblauth enabled auto-merge June 27, 2024 09:13
@sblauth sblauth merged commit 6a83328 into main Jun 27, 2024
25 checks passed
@sblauth sblauth deleted the hotfix/2.1.3 branch June 27, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant