Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs for topology optimization in parallel #514

Merged
merged 3 commits into from
Nov 11, 2024
Merged

Conversation

sblauth
Copy link
Owner

@sblauth sblauth commented Nov 11, 2024

This PR fixes a bug which occurs when running topology optimization problems in parallel with parameters["ghost_mode"] = "shared_vertex" or parameters["ghost_mode"] = "shared_facet".

cashocs also now raises an exception if the angle-weighted interpolation for topological derivatives is used in parallel as this is not supported at the moment.

Closes #208

@sblauth sblauth added the bug Something isn't working label Nov 11, 2024
@sblauth sblauth added this to the v2.3 milestone Nov 11, 2024
@sblauth sblauth self-assigned this Nov 11, 2024
Copy link

codecov bot commented Nov 11, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.96%. Comparing base (b4fa442) to head (902f37a).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
cashocs/_utils/interpolations.py 66.67% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #514      +/-   ##
==========================================
- Coverage   91.97%   91.96%   -0.01%     
==========================================
  Files          84       84              
  Lines        7139     7143       +4     
==========================================
+ Hits         6566     6569       +3     
- Misses        573      574       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sblauth sblauth enabled auto-merge November 11, 2024 13:55
@sblauth sblauth merged commit cba7928 into main Nov 11, 2024
28 checks passed
@sblauth sblauth deleted the dev/mpi_topology branch November 11, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make angle-weighted interpolation for topology optimization available for parallel computing
1 participant