Search: Infinite scrolling and serverside content type filters #562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of using a local filter of `multi`+`game` results.
Doesn't support pagination, fixes showing duplicate games on multi search when scrolling down.
Kind of wanted to display the page number somewhere but I can't think of where it could go
truecharts-admin
referenced
this pull request
in truecharts/public
Jun 28, 2024
….0@2229366 by renovate (#23905) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [ghcr.io/sbondco/watcharr](https://github.com/sbondCo/Watcharr) | minor | `v1.40.0` -> `v1.41.0` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>sbondCo/Watcharr (ghcr.io/sbondco/watcharr)</summary> ### [`v1.41.0`](https://github.com/sbondCo/Watcharr/releases/tag/v1.41.0) [Compare Source](https://github.com/sbondCo/Watcharr/compare/v1.40.0...v1.41.0) #### 🧠 New - Search: Infinite scrolling and serverside content type filters by [@​IRHM](https://github.com/IRHM) in [https://github.com/sbondCo/Watcharr/pull/562](https://github.com/sbondCo/Watcharr/pull/562) - Search now supports scrolling through multiple pages of results, making it possible to find content that may have been hidden in the past. - The search filters (Movies, TV Shows, Games, People) have been reworked to filter through the server, this leads to better results and more of them. - Running search requests will now be cancelled if you navigate away from the page or if you change your search query (helps a lot on slower connections). - Ryot import implementation by [@​oPisiti](https://github.com/oPisiti) in [https://github.com/sbondCo/Watcharr/pull/563](https://github.com/sbondCo/Watcharr/pull/563) #### 💯 Changed - Time unit changes by [@​oPisiti](https://github.com/oPisiti) in [https://github.com/sbondCo/Watcharr/pull/563](https://github.com/sbondCo/Watcharr/pull/563) - Movie/show runtimes are now printed as `24 min` instead of `24m` - Time spent watching stats can now show `months, weeks, days, hours & minutes`, instead of just the previous `hours and minutes`. #### 🏗️ Fixed - Fix server side rating validation for imports, watched episodes and watched seasons in sbondCo/Watcharr@7888e04 #### 🔨 Maintenance - server: bump golang.org/x/crypto from 0.23.0 to 0.24.0 in /server by [@​dependabot](https://github.com/dependabot) in [https://github.com/sbondCo/Watcharr/pull/539](https://github.com/sbondCo/Watcharr/pull/539) - ui: bump prettier from 3.2.5 to 3.3.2 by [@​dependabot](https://github.com/dependabot) in [https://github.com/sbondCo/Watcharr/pull/549](https://github.com/sbondCo/Watcharr/pull/549) - server: bump gorm.io/driver/sqlite from 1.5.5 to 1.5.6 in /server by [@​dependabot](https://github.com/dependabot) in [https://github.com/sbondCo/Watcharr/pull/546](https://github.com/sbondCo/Watcharr/pull/546) - workflow: bump docker/build-push-action from 5 to 6 by [@​dependabot](https://github.com/dependabot) in [https://github.com/sbondCo/Watcharr/pull/545](https://github.com/sbondCo/Watcharr/pull/545) - ui: bump [@​typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/eslint-plugin) from 7.12.0 to 7.14.1 by [@​dependabot](https://github.com/dependabot) in [https://github.com/sbondCo/Watcharr/pull/560](https://github.com/sbondCo/Watcharr/pull/560) - ui: bump svelte-eslint-parser from 0.36.0 to 0.39.2 by [@​dependabot](https://github.com/dependabot) in [https://github.com/sbondCo/Watcharr/pull/559](https://github.com/sbondCo/Watcharr/pull/559) - ui: bump eslint-plugin-svelte from 2.39.0 to 2.41.0 by [@​dependabot](https://github.com/dependabot) in [https://github.com/sbondCo/Watcharr/pull/558](https://github.com/sbondCo/Watcharr/pull/558) - server: bump github.com/go-co-op/gocron/v2 from 2.5.0 to 2.7.0 in /server by [@​dependabot](https://github.com/dependabot) in [https://github.com/sbondCo/Watcharr/pull/557](https://github.com/sbondCo/Watcharr/pull/557) #### 🥇 Credit - Thanks to [@​oPisiti](https://github.com/oPisiti) for making their first (and second) contribution in [https://github.com/sbondCo/Watcharr/pull/563](https://github.com/sbondCo/Watcharr/pull/563) - Thanks to [@​simonbcn](https://github.com/simonbcn) for reporting an issue that led to the search improvements being made in [https://github.com/sbondCo/Watcharr/issues/531](https://github.com/sbondCo/Watcharr/issues/531) #### 🆘 Getting Help If you need help, encounter an issue or find a bug please [create an issue](https://github.com/sbondCo/Watcharr/issues/new/choose) or [join our space on Matrix](https://matrix.to/#/#watcharr:matrix.org) for support. Always happy to help! I spent a lot of time trying to make sure no bugs were introduced with the new search features, please don't hesitate to reach out if you think someone is not working as intended! Package: https://github.com/orgs/sbondCo/packages/container/watcharr/236341139?tag=v1.41.0 or [on docker hub](https://hub.docker.com/layers/sbondco/watcharr/v1.41.0/images/sha256-2229366989b906418c17df5a54c0c6d378f6044f45c591bba81a6cdd25e30a96?context=explore) **Full Changelog**: sbondCo/Watcharr@v1.40.0...v1.41.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjAuMSIsInVwZGF0ZWRJblZlciI6IjM3LjQyMC4xIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIiwibGFiZWxzIjpbImF1dG9tZXJnZSIsInVwZGF0ZS9kb2NrZXIvZ2VuZXJhbC9ub24tbWFqb3IiXX0=-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes made
Search now supports scrolling through multiple pages of results (except for games, I couldn't find anything related to pagination on the igdb docs).
The content type filters now run specific tmdb api requests instead of simply filtering the results displayed in the client.
So basically search is better yippee.
Breaking (for third party tools, if any exist): The content search route for tmdb
multiendpoint has been moved from/content/:queryto/content/search/multi/:queryto accommodate the extra movie, tv and people search endpoints added in this PR.Closes #531