Fix potential leaks in move assignment operator (#17)

sbooth · Sep 25, 2024 · c4f71d6 · c4f71d6
1 parent ba5c23e
commit c4f71d6
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 0 deletions.
diff --git a/Sources/CXXAudioUtilities/include/SFBCAAUGraph.hpp b/Sources/CXXAudioUtilities/include/SFBCAAUGraph.hpp
@@ -50,6 +50,8 @@ class CAAUGraph
 	CAAUGraph& operator=(CAAUGraph&& rhs) noexcept
 	{
 		if(this != &rhs) {
+			if(mAUGraph)
+				DisposeAUGraph(mAUGraph);
 			mAUGraph = rhs.mAUGraph;
 			rhs.mAUGraph = nullptr;
 		}

diff --git a/Sources/CXXAudioUtilities/include/SFBCAAudioConverter.hpp b/Sources/CXXAudioUtilities/include/SFBCAAudioConverter.hpp
@@ -46,6 +46,8 @@ class CAAudioConverter
 	CAAudioConverter& operator=(CAAudioConverter&& rhs) noexcept
 	{
 		if(this != &rhs) {
+			if(mConverter)
+				AudioConverterDispose(mConverter);
 			mConverter = rhs.mConverter;
 			rhs.mConverter = nullptr;
 		}

diff --git a/Sources/CXXAudioUtilities/include/SFBCAAudioFile.hpp b/Sources/CXXAudioUtilities/include/SFBCAAudioFile.hpp
@@ -50,6 +50,8 @@ class CAAudioFile
 	CAAudioFile& operator=(CAAudioFile&& rhs) noexcept
 	{
 		if(this != &rhs) {
+			if(mAudioFileID)
+				AudioFileClose(mAudioFileID);
 			mAudioFileID = rhs.mAudioFileID;
 			rhs.mAudioFileID = nullptr;
 		}

diff --git a/Sources/CXXAudioUtilities/include/SFBCAExtAudioFile.hpp b/Sources/CXXAudioUtilities/include/SFBCAExtAudioFile.hpp
@@ -62,6 +62,8 @@ class CAExtAudioFile
 	CAExtAudioFile& operator=(CAExtAudioFile&& rhs) noexcept
 	{
 		if(this != &rhs) {
+			if(mExtAudioFile)
+				ExtAudioFileDispose(mExtAudioFile);
 			mExtAudioFile = rhs.mExtAudioFile;
 			rhs.mExtAudioFile = nullptr;
 		}