Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with player names containing special characters: quotation marks/apostrophe #610

Closed
borzaka opened this issue Sep 28, 2019 · 4 comments · Fixed by #612
Closed

Problem with player names containing special characters: quotation marks/apostrophe #610

borzaka opened this issue Sep 28, 2019 · 4 comments · Fixed by #612
Assignees

Comments

@borzaka
Copy link
Contributor

borzaka commented Sep 28, 2019

What are the steps to reproduce this issue?

  1. Have a user on the server with quotation mark (or apostrophe) in the name, for example:
    -KODIAK's LaiR- Mantaboy2
  2. Try to get playerinfo (View Profile), or Ban/Block/Kick from the right click menu at the WebPanel.

What happens?

An error shows that the player is not on the server anymore. And therefore you can't get playerinfo, can't ban/kick/etc that player.

Playerinfo:
image

Banning:
image

What were you expecting to happen?

To successfully get playerinfo, able to ban/kick and do everything that WebPanel supports with a player.

Any logs, error output, etc.?

Console log when I tried to get that player info:

hostname: HOSTNAME
version : 1.37.1.5/13715 983/7621 secure  [G:1:0000000] 
udp/ip  : x.x.x.x:27035  (public ip: x.x.x.x)
os      :  Linux
type    :  community dedicated
map     : de_dust2
gotv[0]:  port 27040, delay 105.0s, rate 32.0
players : 5 humans, 1 bots (10/0 max) (not hibernating)

# userid name uniqueid connected ping loss state rate adr
# 8 "GOTV" BOT active 32
# 64 2 "V4Lto♿" STEAM_1:1:000000000 00:27 25 0 active 786432 0.0.0.0:27005
# 63 3 "TaPsI.TT" STEAM_1:0:000000000 04:07 16 0 active 786432 0.0.0.0:58359
# 57 5 "neverz" STEAM_1:0:000000000 25:59 25 0 active 786432 0.0.0.0:27005
# 58 7 "-KODIAK's LaiR- Mantaboy2" STEAM_1:1:000000000 19:00 43 0 active 786432 0.0.0.0:27005
# 54 8 "fazék" STEAM_1:0:000000000 32:23 23 0 active 786432 0.0.0.0:27005
#end
L 09/28/2019 - 12:46:21: rcon from "x.x.x.x:43592": command "status"

Note: I hided any sensitive information.

Any other comments?

What versions of software are you using?

Operating System: Linux 4.19.0-6-amd64 #1 SMP Debian 4.19.67-2 (2019-08-28) x86_64 GNU/Linux (Debian 10.1)
SourceBans++ Version: 1.7.0 | Git: 931
PHP Version: 7.3.4-2
MySQL Version: mariadb Ver 15.1 Distrib 10.3.17-MariaDB, for debian-linux-gnu (x86_64) using readline 5.2
Link to your project: Sorry, I don't want to post it here.
Link to a phpinfo() output: I don't want to post it here.

If you need the last two info, contact me on Discord.

@Groruk Groruk self-assigned this Sep 28, 2019
@CrazyHackGUT
Copy link
Contributor

I hided any sensitive information.

You forget about Steam Server ID. By Steam Server ID, any user can retrieve Server IP with Steam Web API.

@borzaka
Copy link
Contributor Author

borzaka commented Sep 28, 2019

Thank you, I didn't know that was a Steam Server ID.

Groruk added a commit to Groruk/sourcebans-pp that referenced this issue Oct 1, 2019
Currently all $_GET and $_POST data gets filtered with FILTER_SANITIZE_STRING, to combat this in player name checks we now filter both names before comparing them. (Should fix sbpp#610)
@borzaka
Copy link
Contributor Author

borzaka commented Oct 28, 2019

Unfortunately this is still an issue. I can give you a name example which behaves exactly the same as in the opening comment:
/Dominik\®|cs.money

Yes, I have updated my Web Panel files with fixing PR.

@borzaka
Copy link
Contributor Author

borzaka commented May 11, 2020

Another example:
kortemonsta#1514

Web panel says that player is not on the server any more, but he is.

@Hackmastr Hackmastr added this to 1.7.0 Jun 2, 2024
@Hackmastr Hackmastr moved this to Done in 1.7.0 Jun 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants