-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem with player names containing special characters: quotation marks/apostrophe #610
Comments
You forget about Steam Server ID. By Steam Server ID, any user can retrieve Server IP with Steam Web API. |
Thank you, I didn't know that was a Steam Server ID. |
Currently all $_GET and $_POST data gets filtered with FILTER_SANITIZE_STRING, to combat this in player name checks we now filter both names before comparing them. (Should fix sbpp#610)
Unfortunately this is still an issue. I can give you a name example which behaves exactly the same as in the opening comment: Yes, I have updated my Web Panel files with fixing PR. |
Another example: Web panel says that player is not on the server any more, but he is. |
What are the steps to reproduce this issue?
-KODIAK's LaiR- Mantaboy2
What happens?
An error shows that the player is not on the server anymore. And therefore you can't get playerinfo, can't ban/kick/etc that player.
Playerinfo:
Banning:
What were you expecting to happen?
To successfully get playerinfo, able to ban/kick and do everything that WebPanel supports with a player.
Any logs, error output, etc.?
Console log when I tried to get that player info:
Note: I hided any sensitive information.
Any other comments?
What versions of software are you using?
Operating System:
Linux 4.19.0-6-amd64 #1 SMP Debian 4.19.67-2 (2019-08-28) x86_64 GNU/Linux
(Debian 10.1)SourceBans++ Version:
1.7.0 | Git: 931
PHP Version:
7.3.4-2
MySQL Version:
mariadb Ver 15.1 Distrib 10.3.17-MariaDB, for debian-linux-gnu (x86_64) using readline 5.2
Link to your project: Sorry, I don't want to post it here.
Link to a phpinfo() output: I don't want to post it here.
If you need the last two info, contact me on Discord.
The text was updated successfully, but these errors were encountered: