Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include server ID in Native_SBReportPlayer #480

Merged
merged 2 commits into from
Jun 13, 2018
Merged

Conversation

geominorai
Copy link
Contributor

Server ID was missing from the SQL insert statement

Description

Substitute current 0 with serverID global variable.

Motivation and Context

Current SQL statement has a hard-coded 0 for the server table column, which shows as other server on the ban submissions page.

How Has This Been Tested?

Compiled and tested on Linux game server with server ID set in config.
Originating server name confirmed to show properly in ban submissions page on web server.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.

geominorai and others added 2 commits June 12, 2018 04:05
Web panels uses 0 index value for other ban submission/na
@rumblefrog rumblefrog merged commit 695080a into sbpp:v1.x Jun 13, 2018
@rumblefrog
Copy link
Member

Cheers 🎉

@CrazyHackGUT
Copy link
Contributor

Why you just don't get Server ID from DB with subqueries, when Server ID not set? When ban adds into DB, SB tries find own Server ID.

@rumblefrog
Copy link
Member

I'm going to hold off doing that as we are planning to remove the need to enter server ID.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants