Added proper SteamID2 and IP address validation to admin ban page / Switch to userid for kickid #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added http/https distinction in URL where applicable
geominorai
changed the title
|
Added commits to switch to |
|
This will probably fix issue #474. |
|
Renamed the for-loop variables by @codacy-bot's recommendations. |
|
Fixed a bug where a SteamID2 conversion was attempted before checking for an empty string (such as for IP bans). |
web/includes/sb-callback.php
Outdated
|
|
||
| $steam = \SteamID\SteamID::toSteam2(trim($steam)); | ||
| $steam = trim($steam); | ||
| if ($steam) |
There was a problem hiding this comment.
Use empty() function.
There was a problem hiding this comment.
It's acts the same for strings, but alright.
|
Pull has been abandoned and is too far behind master. I'll resync and recreate the patch and pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaces string length tests with regex tests
Fixes not allowing older Steam accounts with a shorter ID length
Includes alternate regex test for community IDs
Switched
kickidto useuseridinstead of Steam ID due to command breakage for TF2 servers.Motivation and Context
How Has This Been Tested?
Tested on Linux web server
Tested on Linux TF2 game server
Types of changes
Checklist: