-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Token based login system #554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For auto password generation
Now managed through Host class
…ed with the steamid
Someone's been a busy boy. 👀 |
More UI changes are following so these buttons should do for now
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Switch from an session based login to a token based system.
This PR also contains changes for:
SB_WP_URL
with a Host class that auto resolves paths instead of users setting it manuallyThese changes affect
#553
#514
FIX #350
FIX #487
(FIX #374)
(FIX #326)
Motivation and Context
While the implementation of the 'Session Based' login model in SourceBans++ wasn't the best from the get go and we could improve that one a bit through more work, it would most likely die in one of the later releases of SourceBans++.
A token based login system would give us a lot more access control in the future, but also aid in the creation of API tokens.
What is still to do?
auth token maxlife
values to settings pageTypes of changes
Checklist: