Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed updater query overlap #562

Merged
merged 1 commit into from
Feb 18, 2019
Merged

Conversation

geominorai
Copy link
Contributor

@geominorai geominorai commented Feb 18, 2019

Patched one SQL query in newest updater script not running due to two overlapping query definitions before execution.

Description

Reordered the queries so they do not overlap

Motivation and Context

Script fails to create :prefix_login_tokens table when running updater to patch from 605->700

How Has This Been Tested?

Ran patched script and :prefix_login_tokens table was successfully created. Additional auth.maxlifetime rows in settings table were added as normal.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.

@Groruk Groruk merged commit a12e2a8 into sbpp:v1.x Feb 18, 2019
@geominorai geominorai deleted the patch/updater/login_tokens branch February 18, 2019 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants