Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow generic admins to view bans/comm blocks & notifications #566

Merged
merged 1 commit into from
Mar 7, 2019
Merged

Allow generic admins to view bans/comm blocks & notifications #566

merged 1 commit into from
Mar 7, 2019

Conversation

sneak-it
Copy link
Contributor

@sneak-it sneak-it commented Mar 7, 2019

Description

Quick and simple, this change allows admins with the Generic flag view all bans, comms, and notifications in the checker module.

Motivation and Context

This PR is a bit of a common-sense, quality of life change. Admins of ALL levels should be able to see current bans/comms status & connecting players with previous infractions. Just because an admin may not have ban permissions, does not mean they will not have all other permissions to enforce whatever actions on players they have been assigned to. Administration should be well-informed, and this is what this PR is aimed at. No sensitive information is revealed with this change.

How Has This Been Tested?

Tested on several live prod servers, working as intended.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality, kinda)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • A bit of a combination of the above, it is a change that modifies existing functionality, but not breaking in any sense of the word.

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.

@sneak-it
Copy link
Contributor Author

sneak-it commented Mar 7, 2019

Quick follow-up: I'm aware that this can be changed in overrides and does not require a plugin change, however this PR is aimed at changing the default behavior. After some discussion on SB discord and with other community owners, this seems to be the most desired behavior.

@Groruk Groruk merged commit a3aadcc into sbpp:v1.x Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants