Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace IpToCountry with MaxMind database. #613

Merged
merged 1 commit into from
Oct 1, 2019
Merged

Replace IpToCountry with MaxMind database. #613

merged 1 commit into from
Oct 1, 2019

Conversation

Hackmastr
Copy link
Contributor

@Hackmastr Hackmastr commented Sep 30, 2019 •
edited
Loading

Replace current country lookup IP with MaxMind's GeoLite2 database.

Description

Motivation and Context

Closes #609.

How Has This Been Tested?

Locally with PHP 7.3.1.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.

@rumblefrog rumblefrog requested a review from Groruk September 30, 2019 23:47
@rumblefrog rumblefrog merged commit 4eb0270 into sbpp:v1.x Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Groruk Groruk Groruk approved these changes

Assignees
No one assigned
Labels
semver: patch t: database/schema t: ui/ux type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace IpToCountry.csv with maxmind's mmdb
4 participants
@Hackmastr @borzaka @Groruk @rumblefrog