Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Standardized Main Chat Prints #614

Merged
merged 1 commit into from
Oct 4, 2019
Merged

refactor: Standardized Main Chat Prints #614

merged 1 commit into from
Oct 4, 2019

Conversation

rumblefrog
Copy link
Member

Description

Removes duplicate Sourcebans and standardized them to Prefix define

Motivation and Context

Clean up and standardization

How Has This Been Tested?

Successfully compiles

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.

@rumblefrog rumblefrog closed this Oct 1, 2019
@rumblefrog rumblefrog reopened this Oct 1, 2019
@rumblefrog rumblefrog marked this pull request as ready for review October 1, 2019 21:52
@CrazyHackGUT
Copy link
Contributor

Maybe you move prefix to translations file?

@rumblefrog
Copy link
Member Author

Perhaps in another PR.

@rumblefrog rumblefrog merged commit 3748c89 into v1.x Oct 4, 2019
@rumblefrog rumblefrog deleted the standardize-chat-prints branch October 4, 2019 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Groruk Groruk Groruk approved these changes

Assignees
No one assigned
Labels
semver: patch t: plugin type: maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rumblefrog @CrazyHackGUT @Groruk