Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CreateLinkR() onclick binding #616

Merged
merged 1 commit into from
Oct 3, 2019
Merged

Fix CreateLinkR() onclick binding #616

merged 1 commit into from
Oct 3, 2019

Conversation

Groruk
Copy link
Member

@Groruk Groruk commented Oct 2, 2019

Fix CreateLinkR() function to properly bind onclick JS functions.

Motivation and Context

Fix #607

How Has This Been Tested?

Tested the affected functions (Unban/Unmute/Ungag and Delete Ban on both ban/comm list)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.

@Groruk Groruk requested a review from rumblefrog October 2, 2019 18:49
rumblefrog
rumblefrog approved these changes Oct 3, 2019
View reviewed changes
Copy link
Member

@rumblefrog rumblefrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff was quite unreadable, not sure why it's displaying a totally changed subset

@Groruk Groruk merged commit 7707282 into sbpp:v1.x Oct 3, 2019
@Groruk Groruk deleted the fix-createlinkr branch October 3, 2019 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rumblefrog rumblefrog rumblefrog approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pressing the Comms/Delete Block or Bans/Delete Ban button does not delete Block/Ban
2 participants
@Groruk @rumblefrog