Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Update builders. #627

Merged
merged 3 commits into from
Oct 19, 2019
Merged

ci: Update builders. #627

merged 3 commits into from
Oct 19, 2019

Conversation

TheByKotik
Copy link
Contributor

Motivation and Context

Treated warnings as errors (flag -E).
Any warnings is potentially maybe issue. It is better to avoid warnings.

Added current dir to include path ($PWD and %CD%)(flag -I<name>).
For prevent failed build. See: #625

Set low verbosity (flag -v<num>).
Just less output info like sourcemod compiler version and done. message.

How Has This Been Tested?

Tested:
1.x branch here: (Travis) (appveyor)
For PR here: (Travis) (appveyor)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.

Treated warnings as errors.
Added current dir to include path ($PWD and %CD%).
Set low verbosity.
@rumblefrog
Copy link
Member

While you at it, can you remove 1.8 from the build matrix and update it to build against the newest SM development version (1.11) and allow it to fail.

@rumblefrog rumblefrog changed the title Update builders. ci: Update builders. Oct 19, 2019
@TheByKotik
Copy link
Contributor Author

TheByKotik commented Oct 19, 2019

Updated SM versions and i'm added matrix for AppVeyor.

(It's so fun. I did this changes in last night and in three hours before when i'm start RP, Alliedmodders have decided bump version)

@rumblefrog rumblefrog requested a review from Groruk October 19, 2019 07:43
@TheByKotik
Copy link
Contributor Author

TheByKotik commented Oct 19, 2019

While you at it, can you remove 1.8 from the build matrix and update it to build against the newest SM development version (1.11) and allow it to fail.

Done and tested.

Results with test error: (Travis) (appveyor)

@Bara
Copy link

Bara commented Oct 19, 2019

Why we need both (travis and appveyor)?

@Bara
Copy link

Bara commented Oct 19, 2019

We can work with github actions and "runs-on" for compiling under linux and windows.

@rumblefrog
Copy link
Member

We could always move to Github's actions down the road; as of right now Github's action is still in a premature state, at least from my experience trying to use it in a Golang project.

@CrazyHackGUT
Copy link
Contributor

I already setuped GitHub Actions for own periodically building plugins. You can try "rewrite" my config.
https://github.com/CrazyHackGUT/sm-uas/blob/master/.github/workflows/blank.yml

@rumblefrog
Copy link
Member

rumblefrog commented Oct 19, 2019

There are a few issues that I'm waiting on to be resolved with actions, so we can potentially have multi-workflow builds and jobs for this repo and the doc repo.

Upload Artifact

Download Artifact

Github Universe 2019 is about a month away; I suspect by then it'll be out of beta.

@rumblefrog rumblefrog merged commit b4c2bb7 into sbpp:v1.x Oct 19, 2019
@Bara
Copy link

Bara commented Oct 19, 2019

@rumblefrog or disable artifact uploads at the beginning. and just compiling the plugins to get the logs.

@TheByKotik TheByKotik deleted the update-builders branch May 18, 2020 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants