Skip to content
This repository has been archived by the owner on Oct 8, 2021. It is now read-only.

Provide read_graphml #39

Merged
merged 1 commit into from
Apr 4, 2015
Merged

Conversation

jiahao
Copy link
Contributor

@jiahao jiahao commented Apr 4, 2015

Reads in GraphML files and returns a LightGraph object.

Requires LightXML as an optional dependency

@coveralls
Copy link

Coverage Status

Coverage decreased (-2.96%) to 91.97% when pulling f1ceffe on jiahao:cjh/read_graphml into 19be9c7 on JuliaGraphs:master.

@jiahao
Copy link
Contributor Author

jiahao commented Apr 4, 2015

What's this package's policy on @doc strings? I see some functions have them commented out. Can we introduce a dependency on Docile.jl to handle 0.3 compatibility?

@coveralls
Copy link

Coverage Status

Coverage decreased (-2.96%) to 91.97% when pulling f1ceffe on jiahao:cjh/read_graphml into 19be9c7 on JuliaGraphs:master.

@sbromberger
Copy link
Owner

What's this package's policy on @doc strings? I see some functions have them commented out. Can we introduce a dependency on Docile.jl to handle 0.3 compatibility?

@jpfairbanks uses them; I don't :) They were commented out because they broke 0.3 without Docile. Given that docstring format is still up in the air for 0.4 I'm inclined to not have them right now.

Reads GraphML files

Requires LightXML as an optional dependency
@jiahao
Copy link
Contributor Author

jiahao commented Apr 4, 2015

Ok, I commented them out.

@sbromberger
Copy link
Owner

This is awesome, btw. Thank you. I'll add some docs later.

sbromberger added a commit that referenced this pull request Apr 4, 2015
@sbromberger sbromberger merged commit 14b1ef5 into sbromberger:master Apr 4, 2015
@jiahao jiahao deleted the cjh/read_graphml branch April 4, 2015 15:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants