Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional alarm name to CloudWatch alarm #3

Merged
merged 4 commits into from
Jun 2, 2017
Merged

Add optional alarm name to CloudWatch alarm #3

merged 4 commits into from
Jun 2, 2017

Conversation

Partyschaum
Copy link
Contributor

No description provided.

README.md Outdated
@@ -35,6 +35,7 @@ custom:
sqs-alarms:
- queue: your-sqs-queue-name
topic: your-sns-topic-name
alarmName: your-alarm-name # optional parameter
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename this to name. But besides that, thank you so much 😍

@sbstjn sbstjn merged commit ad41f40 into sbstjn:master Jun 2, 2017
@Partyschaum Partyschaum deleted the make-alarm-name-configurable branch June 2, 2017 11:24
Copy link
Owner

@sbstjn sbstjn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@sbstjn sbstjn requested review from sbstjn and removed request for sbstjn June 2, 2017 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants