Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jarjar-abrams to 0.3.1 #423

Merged
merged 1 commit into from
Aug 23, 2021
Merged

Conversation

eejbyfeldt
Copy link

The bug fixed in jarjar-abrams 0.3.1 from PR: eed3si9n/jarjar-abrams#10 is preventing us from upgrading sbt-assembly 0.14.9 to 0.15.0

I don't have knowledge of the codebases, so I am expecting CI to make sure that the update is safe.

@eejbyfeldt eejbyfeldt marked this pull request as draft April 7, 2021 13:27
@eejbyfeldt eejbyfeldt force-pushed the bump-jarjar-abrams branch from fbb6c50 to 36e738a Compare June 10, 2021 12:29
@eejbyfeldt eejbyfeldt force-pushed the bump-jarjar-abrams branch from 36e738a to 9d87b0c Compare June 10, 2021 12:33
@ericdotdata
Copy link

@eejbyfeldt can you bump this ticket to restart the CI tests?

@er1c
Copy link

er1c commented Aug 23, 2021

I just verified that this does fix my issue #442

2021-08-23 22:24:40.983Z [pool-1-thread-1-ScalaTest-running-HdfsDiskQuotaExceededTest] ERROR Running on cluster failed, config location is hdfs://sparkmaster:19000/bdcore/tests/integrationTest/executions/Mon_Aug_23_22_23_43_UTC_2021_1629757423455_513478040/results/training/feature_factory/feature_factory.conf, please investigate <k.r.s.ApplicationRunnerForTests$> [ApplicationRunnerForTests.scala:89]
[info] - should should detect, throw and log hdfs limit exceeded exception
[info] Run completed in 1 minute, 1 second.
[info] Total number of tests run: 1
[info] Suites: completed 1, aborted 0
[info] Tests: succeeded 1, failed 0, canceled 0, ignored 0, pending 0
[info] All tests passed.

@eed3si9n eed3si9n marked this pull request as ready for review August 23, 2021 22:28
Copy link
Member

@eed3si9n eed3si9n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@eed3si9n eed3si9n merged commit 65828f3 into sbt:develop Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants