Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to com.github.sbt? #198

Closed
mkurz opened this issue Jan 3, 2022 · 9 comments · Fixed by #205
Closed

Move to com.github.sbt? #198

mkurz opened this issue Jan 3, 2022 · 9 comments · Fixed by #205

Comments

@mkurz
Copy link
Member

mkurz commented Jan 3, 2022

I am a bit wondering why you (still) use com.typesafe.sbt and didn't move to com.github.sbt?
It seems you are the only one still publishing under this id: https://repo1.maven.org/maven2/com/typesafe/sbt/
As far as I understand, now that https://repo.scala-sbt.org/ is read only, sbt-plugins hosted under the sbt Github organisation, started moving to com.github.sbt (https://repo1.maven.org/maven2/com/github/sbt/)

@mkurz
Copy link
Member Author

mkurz commented Jan 3, 2022

/cc @eed3si9n

@raboof
Copy link
Collaborator

raboof commented Jan 3, 2022

I think the reason is mostly just that nobody did it yet ;)

@mkurz
Copy link
Member Author

mkurz commented Jan 3, 2022

That's a good point 😉 So this confirms my assumption that com.github.sbt is the place to be for sbt plugins and com.typesafe.sbt is deprecated. Thanks!

@raboof
Copy link
Collaborator

raboof commented Jan 3, 2022

Don't take my word as authoritative, I haven't followed it closely, but it seems reasonable to me to follow https://github.com/sbt/sbt-unidoc/pull/95/files#diff-5634c415cd8c8504fdb973a3ed092300b43c4b8fc1e184f7249eb29a55511f91R3 and https://github.com/sbt/sbt-ci-release/pull/210/files

@mkurz
Copy link
Member Author

mkurz commented Jan 28, 2022

Just a reminder: When moving to com.github.sbt don't forget to tell scala-steward about it, as an example: scala-steward-org/scala-steward#2488

@SethTisue
Copy link
Member

I believe a PR on this would be welcome.

@mkurz
Copy link
Member Author

mkurz commented Mar 7, 2022

@SethTisue Voilà -> #205

@mkurz
Copy link
Member Author

mkurz commented Mar 7, 2022

@SethTisue Are the sonatype credentials for this repo are set up?

@SethTisue
Copy link
Member

(i'll respond on the PR)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants