Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to com.github.sbt #205

Merged
merged 2 commits into from
Mar 8, 2022
Merged

Switch to com.github.sbt #205

merged 2 commits into from
Mar 8, 2022

Conversation

mkurz
Copy link
Member

@mkurz mkurz commented Mar 7, 2022

Fixes #198

I think it could be that after merging this pull request we already see a snapshot here: https://oss.sonatype.org/content/repositories/snapshots/com/typesafe/sbt/

@mkurz mkurz mentioned this pull request Mar 7, 2022
Closed
@SethTisue
Copy link
Member

@eed3si9n would this change would mean you'd need to re-add the publishing secrets? or would the same secrets still work?

secrets do appear to be in place, and I believe they were used by @raboof to publish 1.0.2

SethTisue
SethTisue reviewed Mar 7, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@SethTisue SethTisue requested a review from eed3si9n March 7, 2022 22:07
@mkurz
Copy link
Member Author

mkurz commented Mar 7, 2022

@SethTisue 1.0.2 was published with groupId com.typesafe.sbt, however switching to com.github.sbt need different credentials. AFAIK @eed3si9n adds those to each project under the sbt GitHub organization individually, by hand, so if I am not wrong he has to jump in here.

@mkurz mkurz mentioned this pull request Mar 7, 2022
Merged
@mkurz
Copy link
Member Author

mkurz commented Mar 7, 2022

Preparing scala-steward for the switch already: scala-steward-org/scala-steward#2545

raboof
raboof approved these changes Mar 8, 2022
View reviewed changes
build.sbt
organization := "com.typesafe.sbt"
sonatypeProfileName := "com.typesafe"
organization := "com.github.sbt"
sonatypeProfileName := "com.github.sbt"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(if the sonatype profile name is equal to the organization I don't think it needs to be specified explicitly - but can't hurt)

@raboof raboof merged commit e322489 into sbt:master Mar 8, 2022
@raboof
Copy link
Collaborator

raboof commented Mar 8, 2022

I think it could be that after merging this pull request we already see a snapshot here: https://oss.sonatype.org/content/repositories/snapshots/com/typesafe/sbt/

I guess you mean https://oss.sonatype.org/content/repositories/snapshots/com/github/sbt/ - but I don't think we publish snapshots from master automatically. That's a good idea though - added #208

@mkurz mkurz deleted the move_to_com.github.sbt branch March 8, 2022 21:56
@SethTisue SethTisue mentioned this pull request Mar 8, 2022
Closed
@armanbilge armanbilge mentioned this pull request Mar 15, 2022
Closed
@raboof raboof mentioned this pull request Mar 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SethTisue SethTisue SethTisue left review comments

@raboof raboof raboof approved these changes

@eed3si9n eed3si9n Awaiting requested review from eed3si9n

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move to com.github.sbt?
3 participants
@mkurz @SethTisue @raboof