Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sbt to 1.10.0 #242

Merged
merged 1 commit into from
Sep 7, 2024
Merged

Update sbt to 1.10.0 #242

merged 1 commit into from
Sep 7, 2024

Conversation

steinybot
Copy link
Contributor

Changes:

  • Updated sbt to 1.10.0 to work with LTS JDK
  • Removed redundant .java-version file
  • Updated .gitignore

@steinybot
Copy link
Contributor Author

There is a note in the README which I don't fully understand. It says that the plugin requires at least Java 8. Why is that? Is that because of the sbt version? Surely that is not a plugin concern to worry about that.

@steinybot
Copy link
Contributor Author

There is a note in the README which I don't fully understand. It says that the plugin requires at least Java 8. Why is that? Is that because of the sbt version? Surely that is not a plugin concern to worry about that.

Oh I see, that's a JGit requirement. I see that in JGit 6 that minimum requirement is going up to Java 11.

@SethTisue
Copy link
Member

SethTisue commented Sep 7, 2024

Thank you! (I got rid of the .gitignore changes, though, I think it's better for people to have all that stuff in their personal global git config, rather than keeping a copy it in every OSS repo.)

@SethTisue SethTisue merged commit 22d64ce into sbt:main Sep 7, 2024
1 check passed
@steinybot steinybot deleted the update-sbt branch September 8, 2024 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants