Perf: Eliminate redundant call to git.describedVersion
#248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before
After
|
|
@SethTisue can you review this? |
SethTisue
approved these changes
Sep 7, 2024
|
Hello, this looks promising in projects I've been working with too - thank you @adpi2 for your contribution and @SethTisue for your quick review ;) I just wanted to kindly follow up and check if there's a timeline for merging and releasing version with these changes. |
|
re: publishing, I've opened #253 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While I was profiling the loading time of softwaremill/sttp build, I noticed that
sbt-gittakes about half of the CPU time. Indeed it seems thatgit.describedVersionis quite expensive as it needs to unpack Git object directories. The problem is this operation is repeated too many times: once for each sub-project of the build (~200 projects in the case of sttp).This PR eliminates the redundant calls to
describedVersion: if the input settings of theThisProjectandThisBuildare the same, the project reusesThisBuild / gitDescribedVersioninstead of recomputing it.On softwaremill/sttp it reduces the loading time by 45% (12 seconds instead of 22).