Cross build with sbt 2.0.0-M2 #255
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agboom
commented
Oct 7, 2024
Comment on lines
-20
to
+22
| if(ConsoleLogger.formatEnabled) Seq("GIT_PAGER_IN_USE" -> "1") | ||
| if(ConsoleAppender.formatEnabledInEnv) Seq("GIT_PAGER_IN_USE" -> "1") |
There was a problem hiding this comment.
Both methods are deprecated, the latter points to Terminal.isColorEnabled, but that one's private. I'm not sure if these will be removed in the final 2.x, but for now I couldn't find a suitable replacement.
agboom
commented
Oct 7, 2024
Comment on lines
+4
to
+5
| > git config core.hookspath /dev/null | ||
| > git config commit.gpgsign false |
There was a problem hiding this comment.
Some scripted tests started to take a very long time. I figured it was waiting for a GPG password prompt, so I added these lines I added before in a plugin of my own. Now they quickly pass on my machine.
|
there is #256 |
|
Let's continue in #256 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this is still a draft and my first attempt at migration. I was looking to contribute to the sbt 2.x plugin migration and found sbt-git to be one that's used often.
I had to disable sbt-ci-release for now, because it doesn't support 2.x yet and uses sbt-git itself as well. So I think we need to do some kind of bootstrap without sbt-ci-release before we can migrate that one too?
Let me know what you think.
Edit: apparently sbt-ci-release was migrated to 2.x just now, so I'll update my PR accordingly
Edit: it seems to be unable to resolve sbt-ci-release
1.6.1+13-1458cb0b-SNAPSHOT, I'm probably missing something here