fix: Use ForkRun for generateJmhSourcesAndResources #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Forking has a couple of benefits: 1. It runs with the full modules for the JVM, so that it doesn't error if you use something from a module such as java.sql 2. If the generation throws an exception, it doesn't kill sbt outright. Taken from pawel-wiejacha@a916d77 Fixes: sbt#190 Co-authored-by: pawel-wiejacha
johanandren
approved these changes
Dec 11, 2023
|
Refs #192 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forking has a couple of benefits:
Taken from pawel-wiejacha@a916d77
Fixes: #190
Co-authored-by: pawel-wiejacha