Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show the displayName of dynamic tests in the sbt output and in the xml test reports #94

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

vasilmkd
Copy link
Contributor

@vasilmkd vasilmkd commented Aug 7, 2024

Adresses #21 (comment) specifically. This is not a comprehensive solution for @DisplayName support, although it could serve as a starting idea.

Here are some outputs of the publishLocal plugin in action:

  1. --display-mode=tree stays unchanged
[info] JUnit Jupiter
[info]   ScalaBundleSortingTest
[info]     bundleSortingTests()
[info]       + ScalaBspBundle
[info]       + ScalaCodeInsightBundle
[info]       + ScalaCompileServerBundle
[info]       + CompilerIntegrationBundle
[info]       + ScalaJpsBundle
[info]       + ScalaCompileServerSharedBundle
[info]       + ScalaConversionBundle
[info]       + DebuggerBundle
[info]       + ScalaReplBundle
[info]       + ScalaDevkitBundle
[info]       + ScalaGradleBundle
[info]       + ScalaIntellilangBundle
[info]       + ScalaJavaDecompilerBundle
[info]       + ScalaI18nBundle
[info]       + SbtApiBundle
[info]       + SbtBundle
[info]       + ScalaBundle
[info]       + ScalaDirectiveBundle
[info]       + ScalaEditorBundle
[info]       + ScalaInspectionBundle
[info]       + ScalaMetaBundle
[info]       + ScalaOptionsBundle
[info]       + ScalaStructureViewBundle
[info]       + TestingSupportBundle
[info]       + ScalaWorksheetBundle
[info] Test run finished: 0 failed, 0 ignored, 25 total, 8.911s
  1. --display-mode=flat now shows the displayName of the dynamic test instead of the test index
[info] Test run started (JUnit Jupiter)
[info] Test org.jetbrains.plugins.scala.internal.bundle.ScalaBundleSortingTest#bundleSortingTests():ScalaBspBundle started
[info] Test org.jetbrains.plugins.scala.internal.bundle.ScalaBundleSortingTest#bundleSortingTests():ScalaCodeInsightBundle started
[info] Test org.jetbrains.plugins.scala.internal.bundle.ScalaBundleSortingTest#bundleSortingTests():ScalaCompileServerBundle started
[info] Test org.jetbrains.plugins.scala.internal.bundle.ScalaBundleSortingTest#bundleSortingTests():CompilerIntegrationBundle started
[info] Test org.jetbrains.plugins.scala.internal.bundle.ScalaBundleSortingTest#bundleSortingTests():ScalaJpsBundle started
[info] Test org.jetbrains.plugins.scala.internal.bundle.ScalaBundleSortingTest#bundleSortingTests():ScalaCompileServerSharedBundle started
[info] Test org.jetbrains.plugins.scala.internal.bundle.ScalaBundleSortingTest#bundleSortingTests():ScalaConversionBundle started
[info] Test org.jetbrains.plugins.scala.internal.bundle.ScalaBundleSortingTest#bundleSortingTests():DebuggerBundle started
[info] Test org.jetbrains.plugins.scala.internal.bundle.ScalaBundleSortingTest#bundleSortingTests():ScalaReplBundle started
[info] Test org.jetbrains.plugins.scala.internal.bundle.ScalaBundleSortingTest#bundleSortingTests():ScalaDevkitBundle started
[info] Test org.jetbrains.plugins.scala.internal.bundle.ScalaBundleSortingTest#bundleSortingTests():ScalaGradleBundle started
[info] Test org.jetbrains.plugins.scala.internal.bundle.ScalaBundleSortingTest#bundleSortingTests():ScalaIntellilangBundle started
[info] Test org.jetbrains.plugins.scala.internal.bundle.ScalaBundleSortingTest#bundleSortingTests():ScalaJavaDecompilerBundle started
[info] Test org.jetbrains.plugins.scala.internal.bundle.ScalaBundleSortingTest#bundleSortingTests():ScalaI18nBundle started
[info] Test org.jetbrains.plugins.scala.internal.bundle.ScalaBundleSortingTest#bundleSortingTests():SbtApiBundle started
[info] Test org.jetbrains.plugins.scala.internal.bundle.ScalaBundleSortingTest#bundleSortingTests():SbtBundle started
[info] Test org.jetbrains.plugins.scala.internal.bundle.ScalaBundleSortingTest#bundleSortingTests():ScalaBundle started
[info] Test org.jetbrains.plugins.scala.internal.bundle.ScalaBundleSortingTest#bundleSortingTests():ScalaDirectiveBundle started
[info] Test org.jetbrains.plugins.scala.internal.bundle.ScalaBundleSortingTest#bundleSortingTests():ScalaEditorBundle started
[info] Test org.jetbrains.plugins.scala.internal.bundle.ScalaBundleSortingTest#bundleSortingTests():ScalaInspectionBundle started
[info] Test org.jetbrains.plugins.scala.internal.bundle.ScalaBundleSortingTest#bundleSortingTests():ScalaMetaBundle started
[info] Test org.jetbrains.plugins.scala.internal.bundle.ScalaBundleSortingTest#bundleSortingTests():ScalaOptionsBundle started
[info] Test org.jetbrains.plugins.scala.internal.bundle.ScalaBundleSortingTest#bundleSortingTests():ScalaStructureViewBundle started
[info] Test org.jetbrains.plugins.scala.internal.bundle.ScalaBundleSortingTest#bundleSortingTests():TestingSupportBundle started
[info] Test org.jetbrains.plugins.scala.internal.bundle.ScalaBundleSortingTest#bundleSortingTests():ScalaWorksheetBundle started
[info] Test run finished: 0 failed, 0 ignored, 25 total, 8.989s

  1. XML test report output of the same test:
<testcase classname="org.jetbrains.plugins.scala.internal.bundle.ScalaBundleSortingTest" name="bundleSortingTests():ScalaBspBundle" time="0.14">
                      
                    </testcase><testcase classname="org.jetbrains.plugins.scala.internal.bundle.ScalaBundleSortingTest" name="bundleSortingTests():ScalaCodeInsightBundle" time="0.119">
                      
                    </testcase><testcase classname="org.jetbrains.plugins.scala.internal.bundle.ScalaBundleSortingTest" name="bundleSortingTests():ScalaCompileServerBundle" time="0.022">
                      
                    </testcase><testcase classname="org.jetbrains.plugins.scala.internal.bundle.ScalaBundleSortingTest" name="bundleSortingTests():CompilerIntegrationBundle" time="0.09">
                      
                    </testcase><testcase classname="org.jetbrains.plugins.scala.internal.bundle.ScalaBundleSortingTest" name="bundleSortingTests():ScalaJpsBundle" time="0.054">
                      
                    </testcase><testcase classname="org.jetbrains.plugins.scala.internal.bundle.ScalaBundleSortingTest" name="bundleSortingTests():ScalaCompileServerSharedBundle" time="0.022">
                      
                    </testcase><testcase classname="org.jetbrains.plugins.scala.internal.bundle.ScalaBundleSortingTest" name="bundleSortingTests():ScalaConversionBundle" time="0.033">
                      
                    </testcase><testcase classname="org.jetbrains.plugins.scala.internal.bundle.ScalaBundleSortingTest" name="bundleSortingTests():DebuggerBundle" time="0.066">
                      
                    </testcase><testcase classname="org.jetbrains.plugins.scala.internal.bundle.ScalaBundleSortingTest" name="bundleSortingTests():ScalaReplBundle" time="0.013">
                      
                    </testcase><testcase classname="org.jetbrains.plugins.scala.internal.bundle.ScalaBundleSortingTest" name="bundleSortingTests():ScalaDevkitBundle" time="0.007">
                      
                    </testcase><testcase classname="org.jetbrains.plugins.scala.internal.bundle.ScalaBundleSortingTest" name="bundleSortingTests():ScalaGradleBundle" time="0.003">
                      
                    </testcase><testcase classname="org.jetbrains.plugins.scala.internal.bundle.ScalaBundleSortingTest" name="bundleSortingTests():ScalaIntellilangBundle" time="0.012">
                      
                    </testcase><testcase classname="org.jetbrains.plugins.scala.internal.bundle.ScalaBundleSortingTest" name="bundleSortingTests():ScalaJavaDecompilerBundle" time="0.003">
                      
                    </testcase><testcase classname="org.jetbrains.plugins.scala.internal.bundle.ScalaBundleSortingTest" name="bundleSortingTests():ScalaI18nBundle" time="0.009">
                      
                    </testcase><testcase classname="org.jetbrains.plugins.scala.internal.bundle.ScalaBundleSortingTest" name="bundleSortingTests():SbtApiBundle" time="0.018">
                      
                    </testcase><testcase classname="org.jetbrains.plugins.scala.internal.bundle.ScalaBundleSortingTest" name="bundleSortingTests():SbtBundle" time="0.129">
                      
                    </testcase><testcase classname="org.jetbrains.plugins.scala.internal.bundle.ScalaBundleSortingTest" name="bundleSortingTests():ScalaBundle" time="1.66">
                      
                    </testcase><testcase classname="org.jetbrains.plugins.scala.internal.bundle.ScalaBundleSortingTest" name="bundleSortingTests():ScalaDirectiveBundle" time="1.307">
                      
                    </testcase><testcase classname="org.jetbrains.plugins.scala.internal.bundle.ScalaBundleSortingTest" name="bundleSortingTests():ScalaEditorBundle" time="1.282">
                      
                    </testcase><testcase classname="org.jetbrains.plugins.scala.internal.bundle.ScalaBundleSortingTest" name="bundleSortingTests():ScalaInspectionBundle" time="1.285">
                      
                    </testcase><testcase classname="org.jetbrains.plugins.scala.internal.bundle.ScalaBundleSortingTest" name="bundleSortingTests():ScalaMetaBundle" time="1.278">
                      
                    </testcase><testcase classname="org.jetbrains.plugins.scala.internal.bundle.ScalaBundleSortingTest" name="bundleSortingTests():ScalaOptionsBundle" time="1.287">
                      
                    </testcase><testcase classname="org.jetbrains.plugins.scala.internal.bundle.ScalaBundleSortingTest" name="bundleSortingTests():ScalaStructureViewBundle" time="0.012">
                      
                    </testcase><testcase classname="org.jetbrains.plugins.scala.internal.bundle.ScalaBundleSortingTest" name="bundleSortingTests():TestingSupportBundle" time="0.054">
                      
                    </testcase><testcase classname="org.jetbrains.plugins.scala.internal.bundle.ScalaBundleSortingTest" name="bundleSortingTests():ScalaWorksheetBundle" time="0.056">
                      
                    </testcase>

Copy link
Member

@eed3si9n eed3si9n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@eed3si9n eed3si9n merged commit e56ee57 into sbt:main Aug 7, 2024
5 checks passed
@vasilmkd vasilmkd deleted the dynamic-tests branch August 7, 2024 17:50
@vasilmkd
Copy link
Contributor Author

vasilmkd commented Aug 7, 2024

You're welcome. I'm happy to say that we've integrated sbt-jupiter-interface in the Scala Plugin for IDEA repository. Currently alongside junit-interface.

This was the first thing I noticed. I'll contribute more changes as we discover more things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants