DockerAlias should use dockerRepository and dockerUsername from Docker scope #1092
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When originally introduced in 885541e
dockerTarget
useddockerRepository
anddockerUsername
defined in theDocker
scope.Sometime in the process of
dockerTarget
being refactored and renamed todockerTag
and thendockerAlias
, it was made to use the value fromdockerRepository
from the global scope instead of the docker scope. ie, definingused to work, but now has no effect, as shown by looking up the value of dockerAlias:
Instead one must define them globally
I believe this was unintentional, and there's a fair amount of code out there still using the
Docker
scope fordockerRepository
. This change reverts back to using theDocker
scope fordockerRepository
anddockerUsername
when determining the docker alias. This change should be backwards-compatible as defining dockerRepository or dockerUsername on theGlobal
scope means it's also inherited by theDocker
scope.Tested locally by defining
dockerRepository
both with no scope and with theDocker
scope in a build file and examining the value ofdocker:dockerAlias
. Happy to add a scripted test if required.