Support Docker volumes. #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docker has a feature where it can import or export "volumes", or subtrees of the filesystem which can be shared in different ways between Docker containers, or between a container and the host machine. This adds the command to the Dockerfile which sets up the knowledge inside Docker. Also, if a directory is created which does not exist, it will be owned by root. This would be unfortunate if, for example, the exported directory was the logs/ directory for Play. So the directories are created beforehand.
| @@ -27,12 +27,27 @@ trait DockerPlugin extends Plugin with UniversalPlugin { | |||
| Some(Cmd("EXPOSE", exposedPorts.mkString(" "))) | |||
| } | |||
|
|
|||
| Dockerfile(dockerCommands ++ exposeCommand: _*).makeContent | |||
There was a problem hiding this comment.
Thanks a lot for documenting these edge cases! Keep up the good work.
|
Could you write a small test case for this? It should be possible to check the resulting dockerfile? Thanks :) |
|
Added a positive test that the lines are present when the value is set. |
|
Perfect. Let's wait for travis and then this is good to merge. |
|
Great, thanks for your reviews 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docker has a feature where it can import or export "volumes", or subtrees of
the filesystem which can be shared in different ways between Docker containers,
or between a container and the host machine.
This adds the command to the Dockerfile which sets up the knowledge inside
Docker. Also, if a directory is created which does not exist, it will be owned
by root. This would be unfortunate if, for example, the exported directory
was the logs/ directory for Play. So the directories are created beforehand.