Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed wrong archive name in jdeb packaging #328

Merged
merged 1 commit into from
Aug 21, 2014

Conversation

kardapoltsev
Copy link
Member

Jdeb packagind don't use packageArchitecture while generating debian archive filename.

@kardapoltsev
Copy link
Member Author

I'm wanna to use jdeb packaging because it's up to 8 times faster, but there are some many bugs here =)

Also, @jsuereth, @muuki88 if I made some minor changes and travis build has passed, should I create PR or I could just push it to repo?

@muuki88
Copy link
Contributor

muuki88 commented Aug 21, 2014

Always PR (unless it's minor README changes or stuff regarding release script, which doesn't affect the plugin itself) :)

@muuki88 muuki88 added this to the 0.8.0 - windows services milestone Aug 21, 2014
@muuki88
Copy link
Contributor

muuki88 commented Aug 21, 2014

LGTM. Keep up these kind of small refactorings. I hope I find some time to refactor the installation-scripts stuff at some time :/

muuki88 added a commit that referenced this pull request Aug 21, 2014
Fixed wrong archive name in jdeb packaging
@muuki88 muuki88 merged commit d334c80 into sbt:master Aug 21, 2014
@muuki88 muuki88 added the v0.7.x label Aug 21, 2014
@muuki88
Copy link
Contributor

muuki88 commented Aug 21, 2014

merged into v0.7.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants