-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Win exit code fix #421
Win exit code fix #421
Conversation
the `shift` command of cmd.exe is not shift `%*`. and use delayed-expansion. immediate expansion cause many troubles of special-characters in arguments.
Conflicts: src/sbt-test/windows/java-app-archetype/build.sbt
The maintainer line is optional in the Dockerfile. While the initial commit assumed that it was required, it appears that this is not the case. We can therefore skip adding the line if the maintainer is not set.
This reverts commit 20d56d6.
Return exit code 1 in windows bat script if java application exits with a return code greater than 0. Update windows bat regression tests to check the returned code.
Hi @bjuric, Thank you for your contribution! We really value the time you've taken to put this together. Before we proceed with reviewing this pull request, please sign the Typesafe Contributors License Agreement: |
Accepted CLA. |
Thanks for the fix @bjuric . You branched away from You could
You changed an existing test, but only check for object Main extends App {
sys.exit(1)
} |
Created new pull request #423 |
I'll close this in favor of #423 |
Moved the setting of the exit code in the windows bat template outside of the localised scope. This ensures that if the call to the java application returns an exit code greater than 0 that the script returns 1 instead of 0.
Also updated regression tests for windows bat testing to check the return code.
The changes were applied to the 0.8.0 branch.
Developed and tested on Windows 7 SP1.