Removing JavaC dependency in *.bat #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javac is never used in batch script and a normal project should depend on it during runtime.
|
Maybe the Oppan Redmond OR could be also removed… |
|
Ah, thanks for the fix. That was leftover from using this for Activator/sbt. |
jsuereth
added a commit
that referenced
this pull request
Nov 7, 2013
Removing JavaC dependency in *.bat
|
How long will it take until this path is deployed? (Or when could I stop to manually fix the bat file manually after every 'dist'?) |
|
I can cut a patch release soon. I need to backport this into a branch, because the latest has diverged past binary compatibility. I'll see if I can get you a release tomorrow. If not, it'll be 2 weeks as I'm on travel. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi everyone,
just stumbled over the fact that the bat script requires the Java compiler, but never use it. (and the bash script never mention the javac.)
May I miss a situation where javac is required, otherwise it would be nice if this pull will be accepted.
Kind regards, Jentsch