Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX #662 and make universal archive options customizable #666

Merged
merged 1 commit into from
Sep 9, 2015
Merged

FIX #662 and make universal archive options customizable #666

merged 1 commit into from
Sep 9, 2015

Conversation

muuki88
Copy link
Contributor

@muuki88 muuki88 commented Sep 7, 2015

@muuki88 muuki88 added the universal Zip, tar.gz, tgz and bash issues label Sep 7, 2015
muuki88
muuki88 reviewed Sep 7, 2015
View reviewed changes
src/main/scala/com/typesafe/sbt/packager/universal/Archives.scala
* @return dmg file
*/
def makeDmg(target: File, name: String, mappings: Seq[(File, String)], top: Option[String]): File = {
def makeDmg(target: File, name: String, mappings: Seq[(File, String)], top: Option[String], options: Seq[String]): File = {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codacy Issue found: Method is longer than 50 lines

@mackler
Copy link
Contributor

mackler commented Sep 8, 2015

Thanks for doing this. I can see I would have been unable to figure this out myself.

@muuki88
Copy link
Contributor Author

muuki88 commented Sep 9, 2015

@sumkincpp we made the --force-local customizable. With the next release you will can add this option for your build.

muuki88 added a commit that referenced this pull request Sep 9, 2015
@muuki88
Merge pull request #666 from sbt/wip/tar-options
a16c9ec 
FIX #662 and make universal archive options customizable
@muuki88 muuki88 merged commit a16c9ec into master Sep 9, 2015
@muuki88 muuki88 deleted the wip/tar-options branch September 9, 2015 16:27
This was referenced Jan 21, 2016
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
universal Zip, tar.gz, tgz and bash issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@muuki88 @mackler