Fixes for RPM related functionality in 1.0.5-M2 #668
Conversation
…clared
Use normal bash `if` statement as opposed to `[ -n "${MY_VAR}" ] && ...` as the latter
will cause the preinst script to fail if the condition check returns false
|
Manual Tests Scenario:
For each scenario, ensure:
Tested on Centos7 I think the issues raised in this PR is mainly caused by the fact that I was overriding the I have now taken a different approach:
With this approach, I now have a better confidence around the changes I have made. Hopefully this turns out to be the case. |
| if [ -n "$RPM_INSTALL_PREFIX" ] ; | ||
| then | ||
| echo "PACKAGE_PREFIX=${RPM_INSTALL_PREFIX}" >> /etc/sysconfig/${{app_name}} | ||
| fi |
There was a problem hiding this comment.
Were these changes necessary?
There was a problem hiding this comment.
Yes, without these changes the preinst script will fail and abort should the if condition turns out to be false.
Without rpmPrefix being specified, the [ -n "$RPM_INSTALL_PREFIX" ] will return false, and the preinst will abort with a failure.
|
One small comment, otherwise LGTM |
Fixes for RPM related functionality in 1.0.5-M2
|
LGTM. Thanks :) |
|
Release in |
|
Thanks! |
The fixes address the following issues.
Ensure RPM preinst script continues normally when
rpmPrefixis not declaredWithout this fix, when
rpmPrefixis not declared, thepreinstwill terminate in error.Ensure application is running on the installed directory in the RPM-based distribution
This was fixed as part of PR #653 which was accidentally removed in PR #661. Tests are added to prevent this regression from occurring.