sbt 1.0 support #19
sbt 1.0 support #19
Conversation
| @@ -1 +1 @@ | |||
| sbt.version=0.12.4 | |||
| sbt.version=0.13.16 | |||
There was a problem hiding this comment.
I suggest removing build.properties from scripted tests.
| val proguardVersion = SettingKey[String]("proguard-version") | ||
| val proguardDirectory = SettingKey[File]("proguard-directory") | ||
| val proguardConfiguration = SettingKey[File]("proguard-configuration") | ||
| val binaryDeps = TaskKey[Seq[File]]("binaryDeps") |
There was a problem hiding this comment.
The key should have proguard prefixed, as proguardBinaryDeps, and use lower cased taskKey[Seq[File]]("...").
http://www.scala-sbt.org/1.x/docs/Plugins-Best-Practices.html#Avoid+namespace+clashes
The same for rest of the keys.
|
|
||
| val Proguard = config("proguard").hide | ||
| object SbtProguard extends AutoPlugin { | ||
|
|
There was a problem hiding this comment.
AutoPlugin that uses built-in key should include:
override def requires = plugins.JvmPlugin| @@ -1,23 +1,25 @@ | |||
| import sbt._ | |||
| import sbt.Keys._ | |||
| import com.typesafe.sbt.SbtProguard._ | |||
| import com.typesafe.sbt.SbtProguard.autoImport._ | |||
| import com.typesafe.sbt.SbtProguard | |||
|
|
|||
| object SampleBuild extends Build { | |||
There was a problem hiding this comment.
Build trait won't work for sbt 1, if we want to run scripted test on it.
|
Nice! |
|
I just did a drive-by review, but we should get ok from @pvlugter. |
|
Would a release including that be underway? I'll use it straightaway in coursier/coursier#629. |
|
A release would be awesome. |
|
New release: |
I replaced all the deprecated operators and changed this to be an autoPlugin and now it compiles with sbt 0.13.16 and sbt 1.0.0
Because of these changes the pr is not compatible with sbt 0.12 anymore.
The tests all pass, and everything seems to work fine, but I am still new to sbt plugin development and have not yet submitted many prs so feedback is appreciated if things are done improperly.