Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update sbt 0.13.15. fix warnings #100

Merged
merged 1 commit into from
Jun 7, 2017
Merged

update sbt 0.13.15. fix warnings #100

merged 1 commit into from
Jun 7, 2017

Conversation

xuwei-k
Copy link
Member

@xuwei-k xuwei-k commented Jun 5, 2017

jonas
jonas approved these changes Jun 6, 2017
View reviewed changes
Copy link
Member

@jonas jonas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Another set of eyes would be great before merging.

@jonas
Copy link
Member

jonas commented Jun 6, 2017

Thanks so much for doing this. One of the blockers for cross compiling to sbt 1.0.

@metasim
Copy link
Member

metasim commented Jun 7, 2017

LGTM. @xuwei-k Thanks so much for taking care of this.

@metasim metasim merged commit cdac47e into sbt:develop Jun 7, 2017
@xuwei-k xuwei-k deleted the update-sbt branch June 7, 2017 13:39
@jonas jonas modified the milestone: 1.2.1 Jun 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonas jonas jonas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.2.1
Development

Successfully merging this pull request may close these issues.
3 participants
@xuwei-k @jonas @metasim