-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Asciidoctor attribute support #157
Conversation
Hi @mhogerheijde, Thank you for your contribution! We really value the time you've taken to put this together. Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement: |
I have since the initial check accepted the CLA. Is the check repeated automatically? |
Can we re-check the CLA? |
I checked the CLA manually and it's OK. |
At least one pull request committer is not linked to a user. See https://help.github.com/en/articles/why-are-my-commits-linked-to-the-wrong-user#commits-are-not-linked-to-any-user |
I've included an en-passant update to latest version of AsciidoctorJ. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
But now the latest commit has a different author, that's why CLA checking fails:
Can you squash it and provide the correct author, please. |
Ah, that's why. I'll recommit using my personal git-id. Is there a standard way of doing work in company time and using the git-id from my company with the same Github user-account? |
Oh, PEBCAK, just read the CLA stuff again for when it is corporate. I'll contribute from my personal account 👍 |
Also update AsciidoctorJ to latest version
Just came across this, sorry that it kept dangling for so long. |
Fixes #156
Allows users to configure
attributes
for Asciidoctor. They are described here: https://asciidoctor.org/docs/user-manual/#attributes