Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Asciidoctor attribute support #157

Merged
merged 1 commit into from
Sep 24, 2020
Merged

Add Asciidoctor attribute support #157

merged 1 commit into from
Sep 24, 2020

Conversation

mhogerheijde
Copy link
Contributor

Fixes #156

Allows users to configure attributes for Asciidoctor. They are described here: https://asciidoctor.org/docs/user-manual/#attributes

@lightbend-cla-validator

Hi @mhogerheijde,

Thank you for your contribution! We really value the time you've taken to put this together.

Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement:

http://www.lightbend.com/contribute/cla

@mhogerheijde
Copy link
Contributor Author

I have since the initial check accepted the CLA. Is the check repeated automatically?

@mhogerheijde
Copy link
Contributor Author

Can we re-check the CLA?

@ennru
Copy link
Contributor

ennru commented Nov 4, 2019

I checked the CLA manually and it's OK.

@lightbend-cla-validator
Copy link

At least one pull request committer is not linked to a user. See https://help.github.com/en/articles/why-are-my-commits-linked-to-the-wrong-user#commits-are-not-linked-to-any-user

@mhogerheijde
Copy link
Contributor Author

I've included an en-passant update to latest version of AsciidoctorJ.

@ennru ennru added this to the 1.4.1 milestone Nov 6, 2019
Copy link
Contributor

@ennru ennru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ennru
Copy link
Contributor

ennru commented Nov 6, 2019

But now the latest commit has a different author, that's why CLA checking fails:

Author: Matthias Hogerheijde <matthias.hogerheijde@v**a.com>
Author: Matthias Hogerheijde <matthias.hogerheijde@e**i.nl>

Can you squash it and provide the correct author, please.

@mhogerheijde
Copy link
Contributor Author

Ah, that's why.

I'll recommit using my personal git-id. Is there a standard way of doing work in company time and using the git-id from my company with the same Github user-account?

@mhogerheijde
Copy link
Contributor Author

Oh, PEBCAK, just read the CLA stuff again for when it is corporate.

I'll contribute from my personal account 👍

Also update AsciidoctorJ to latest version
@ennru ennru merged commit 5aab1d9 into sbt:develop Sep 24, 2020
@ennru
Copy link
Contributor

ennru commented Sep 24, 2020

Just came across this, sorry that it kept dangling for so long.

@mhogerheijde mhogerheijde deleted the asciidoctor-attribute-support branch September 24, 2020 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow setting custom attributes for Asciidoctor
3 participants