Total makeover: split into modules per generator #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Split into separate plugins per site generator to avoid dependency overload in the using sbt builds.
This was referenced Jan 5, 2023
|
This split makes dependency hell slightly cooler and I have tested the Paradox taste on some Akka projects locally. I intend to merge and release this as 1.5.0-RC2. |
johanandren
approved these changes
Jan 11, 2023
| The `previewSite` plugin does not enable itself anymore, you need to explicitly enable the parts of sbt-site you need on the sbt project/module containing the documentation. To allow `previewSite` with Paradox for example | ||
| ```scala | ||
| .enablePlugins(SitePreviewPlugin, ParadoxSitePlugin) | ||
| ``` |
There was a problem hiding this comment.
Add something about the deprecated/no longer working modules here as well?
ennru
changed the title
xuwei-k
reviewed
May 13, 2023
Comment on lines
+5
to
+9
| addSbtPlugin( | ||
| ("com.github.sbt" % "sbt-ghpages" % "0.7.0") | ||
| // sbt-ghpages depends on sbt-site 1.4.1, which pulls Scala XML 1.x | ||
| .exclude("org.scala-lang.modules", "scala-xml_2.12") | ||
| ) |
There was a problem hiding this comment.
0.8.0 released https://github.com/sbt/sbt-ghpages/releases/tag/v0.8.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split into separate plugins per site generator to avoid dependency overload in the using sbt builds.
Both Scala XML and Scala Parser Generators appear in dependencies, many very outdated and likely unmaintained.
Not all perviously supported site generators are prepared in this PR.
Available are:
Docs still need work to reflect the new structure better.
Another dimension in dependency hell is that sbt-ghpages depends on sbt-site 1.4.4 (not obvious to me why). With sbt-site moving to a different group ID (com.github.sbt) that might create unexpected effects.