Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade ParadoxSitePlugin to sbt-paradox 0.2.9 #93

Merged
merged 1 commit into from
Apr 19, 2017

Conversation

sirthias
Copy link
Contributor

sbt-site 1.2.0 is incompatible with sbt-paradox 0.2.9.
Having these both plugins enabled with these versions causes this exception at sbt startup:

java.lang.NoSuchMethodError: com.lightbend.paradox.sbt.ParadoxPlugin$.paradoxSettings()Lscala/collection/Seq;
	at com.typesafe.sbt.site.paradox.ParadoxSitePlugin$.paradoxSettings(ParadoxSitePlugin.scala:25)
...

This patch fixes the problem.

@jonas
Copy link
Member

jonas commented Feb 14, 2017

It looks like one of the content checks failed in the paradox tests. Did the output directory change?

@sirthias
Copy link
Contributor Author

Ok, paradox 0.2.9 is broken in that

def paradoxSettings(config: Configuration): Seq[Setting[_]] = ...

ends up setting sourceDirectory in paradox to .../paradox/paradox when parameterized with sbt-site's Paradox config.

I fixed it now by manually reversing the effect here, so this patch should now properly work against paradox 0.2.9, but we'll also need an upstream fix in paradox itself.
I'll open a ticket there.

@jonas jonas merged commit e214391 into sbt:develop Apr 19, 2017
@jonas
Copy link
Member

jonas commented Apr 19, 2017

Thanks for adding the workaround.

@jonas jonas added this to the 1.2.1 milestone Jun 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants