JLine 3.24.1 and JAnsi 2.4.0.

[hvesalai]

Fix #7371

• https://github.com/fusesource/jansi/releases/tag/jansi-2.4.1
• https://github.com/jline/jline3/releases/tag/jline-parent-3.24.1

[hvesalai]

This PR is still waiting for an update on sbt/jline2.

[SethTisue]

JLine 3.24 doesn't work on JDK 8 — better stop at 3.23 (reference: scala/scala-dev#856)

(I think that's what Yoshida-san is trying to alert us to, above)

[hvesalai]

JLine 3.24 contains the fix I need. I could ask the developer of JLine to backport it to 3.23.1, but I don't know how he will feel about it since no other such patch releases have been done in the past. I made the request: jline/jline3#888

Optionally we could create our own branch of JLine3 as we have done with JLine2, but at some point cleaning up the whole JLine dependency thing should be planned. I can help if there is a clear direction we are going to take.

Does this imply that scala will try to support JDK8 for ever?

[SethTisue]

Does this imply that scala will try to support JDK8 for ever?

Unclear. So far, keeping support hasn't been painful. Perhaps at some point we'll decide a tipping point has been reached for the costs of continuing support have become too high.

Anyway, it's a moot point for now, as I see that the JLine 3 maintainer just said that they will restore JDK 8 support in 3.24.1. So let's wait for that.

[hvesalai]

Updated the PR with JLine 3.24.1 (was 3.24.0)

[hvesalai]

@eed3si9n did you get a chance to release sbt/jline2 already? If you could tell the version number, I can update it to this PR.

[eed3si9n]

Yea, I released it - https://repo1.maven.org/maven2/org/scala-sbt/jline/jline/2.14.7-sbt-9c3b6aca11c57e339441442bbf58e550cdfecb79/

[eed3si9n]

Thanks!

[lrytz]

When I take current 1.10.x, run sbt publishLocal, then rm -rf ~/.sbt/boot/scala-2.12.18/org.scala-sbt/sbt/1.9.7-SNAPSHOT and then try 1.9.7-SNAPSHOT in a test project, I get

➜ sbtproj sbt
[info] [launcher] getting org.scala-sbt sbt 1.9.7-SNAPSHOT  (this may take some time)...
java.lang.NoClassDefFoundError: org/jline/terminal/spi/JansiSupport
	at java.base/java.lang.ClassLoader.defineClass1(Native Method)
	at java.base/java.lang.ClassLoader.defineClass(ClassLoader.java:1027)
	at java.base/java.security.SecureClassLoader.defineClass(SecureClassLoader.java:150)
	at java.base/java.net.URLClassLoader.defineClass(URLClassLoader.java:524)
	at java.base/java.net.URLClassLoader$1.run(URLClassLoader.java:427)
	at java.base/java.net.URLClassLoader$1.run(URLClassLoader.java:421)
	at java.base/java.security.AccessController.doPrivileged(AccessController.java:714)
	at java.base/java.net.URLClassLoader.findClass(URLClassLoader.java:420)
	at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:593)
	at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:580)
	at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:580)
	at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:580)
	at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:526)
	at sbt.internal.util.JLine3$.<init>(JLine3.scala:53)
	at sbt.internal.util.JLine3$.<clinit>(JLine3.scala)
	at sbt.internal.util.Terminal$.newConsoleTerminal(Terminal.scala:805)
	at sbt.internal.util.Terminal$.withStreams(Terminal.scala:386)
	at sbt.xMain$.withStreams$1(Main.scala:88)
	at sbt.xMain$.run(Main.scala:123)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at sbt.internal.XMainConfiguration.run(XMainConfiguration.java:59)
	at sbt.xMain.run(Main.scala:47)
	at xsbt.boot.Launch$.$anonfun$run$1(Launch.scala:149)
	at xsbt.boot.Launch$.withContextLoader(Launch.scala:176)
	at xsbt.boot.Launch$.run(Launch.scala:149)
	at xsbt.boot.Launch$.$anonfun$apply$1(Launch.scala:44)
	at xsbt.boot.Launch$.launch(Launch.scala:159)
	at xsbt.boot.Launch$.apply(Launch.scala:44)
	at xsbt.boot.Launch$.apply(Launch.scala:21)
	at xsbt.boot.Boot$.runImpl(Boot.scala:78)
	at xsbt.boot.Boot$.run(Boot.scala:73)
	at xsbt.boot.Boot$.main(Boot.scala:21)
	at xsbt.boot.Boot.main(Boot.scala)
Caused by: java.lang.ClassNotFoundException: org.jline.terminal.spi.JansiSupport
	at java.base/java.net.URLClassLoader.findClass(URLClassLoader.java:445)
	at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:593)
	at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:526)
	... 34 more
[error] [launcher] error during sbt launcher: java.lang.NoClassDefFoundError: org/jline/terminal/spi/JansiSupport

@hvesalai / @eed3si9n does it work for you?

[lrytz]

macOS 14.2, OpenJDK Runtime Environment Temurin-17.0.9+9 (build 17.0.9+9)

[eed3si9n]

I can reproduce the problem. The fix is to bump the version number to 1.10.0-SNAPSHOT. This is likely side effect of multi-repo (Zinc etc) using util packages from sbt/sbt but with 1.10.0-M1.

[lrytz]

Thanks Eugene, that fixes it 👍