Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sbt-assembly to 2.3.0 #1444

Open
wants to merge 1 commit into
base: 1.10.x
Choose a base branch
from

Conversation

scala-steward
Copy link
Contributor

@scala-steward scala-steward commented Oct 8, 2024

About this PR

πŸ“¦ Updates com.eed3si9n:sbt-assembly from 2.2.0 to 2.3.0

πŸ“œ GitHub Release Notes - Version Diff

Usage

βœ… Please merge!

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

βš™ Adjust future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "com.eed3si9n", artifactId = "sbt-assembly" } ]

Or, add this to slow down future updates of this dependency:

dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "com.eed3si9n", artifactId = "sbt-assembly" }
}]
labels: sbt-plugin-update, early-semver-minor, semver-spec-minor, commit-count:1

@xuwei-k
Copy link
Member

xuwei-k commented Oct 9, 2024

[error] java.lang.RuntimeException: exportJars must be set to false for the shading to work
[error] 	at scala.sys.package$.error(package.scala:30)
[error] 	at sbtassembly.AssemblyPlugin$.$anonfun$assemblyOptionSettings$1(AssemblyPlugin.scala:113)
[error] 	at scala.Function1.$anonfun$compose$1(Function1.scala:49)

πŸ€”

@mzuehlke
Copy link

mzuehlke commented Oct 9, 2024

The shading logic assumes exportJars := false.

sbt/sbt-assembly#534

@eed3si9n
Copy link
Member

Yea, it's an oversight in the current implementation of how the shading is implemented. I created an issue for it now - sbt/sbt-assembly#537

@scala-steward scala-steward force-pushed the update/sbt-assembly-2.3.0 branch from 2a3892a to 6043036 Compare November 27, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants